#165 – Minutes picker on Return

Posted in ‘Taxi Booking for Joomla’
This is a public ticket. Everybody will be able to see its contents. Do not include usernames, passwords or any other sensitive information.
Friday, 07 November 2014 23:29 GMT
serguei_kp
SystemPay for Taxi Booking, Taxi Booking recurring updates Annually
 Hi, a little bug,
when check Return check-box and the return date is the same as the departure date, if you set, for example,
départure 14 hours 45min + return at 18 hours the minutes in the minutes picker will be available only from 50 min, but if client wants return at 18 hours 15 minutes ? See the attachment.

Regards.
Attachment
 
Saturday, 08 November 2014 14:28 GMT
serguei_kp
SystemPay for Taxi Booking, Taxi Booking recurring updates Annually
Hi Marian, I think that I found a solution to this bug, can you please check if I missed something ?

In : components\com_taxibooking\assets\js\onepage_taxibooking.js and in modules\mod_taxibooking\assets\js\modtaxibooking.js

In funciton compareDate put ">=" instead of ">" , like this :

if(order_return_date_year>=order_date_year) { /* aramis >= au lieu de > */
return true;
}
else {
if(order_return_date_month>=order_date_month) {
return true;
}
else {
if(order_return_date_day>=order_date_day) { /* fin aramis */
return true;
}
else {
return false;
}
}
}

Regards.
 
Saturday, 08 November 2014 17:07 GMT
serguei_kp
SystemPay for Taxi Booking, Taxi Booking recurring updates Annually
Sorry better is to replace :
var min = parseInt(tbjQuery('input#selPtMn1').val())+5;
by var min =0;
 
Sunday, 09 November 2014 14:44 GMT 10'
ronniee
RedSys for Taxi Booking
Hi Serguei,

Thanks a lot for your research. If you please send us temporary FTP access, we will check and fix this issue directly on your site and will also add this fix in next release so that you can safely update.

Best regards
Ronniee
 
Monday, 10 November 2014 10:52 GMT 10'
martso
SumUp for Taxi Booking J4
Hi again Serge,
I think, in a sense your solution will work
var min = parseInt(tbjQuery('input#selPtMn1').val())+5;
by var min =0;
As user can't select the same return hour as pickup hour, so we can safely show all mins starting from zero in Return Minutes list. We will add this fix in next release.
And, currently it is not possible to calculate trip duration right after user chooses both pickup and dropoff, so it is not possible also to implement your suggestion. But, we will think about this for sure.

Thanks a lot
 
This ticket is closed, therefore read-only. You can no longer reply to it. If you need to provide more information, please open a new ticket and mention this ticket's number.

KANEV Web Development limited is not affiliated with or endorsed by the Joomla Project or Open Source Matters.

KANEV Web Development limited is registered in England and Wales #8902407